luoluoyuyu commented on PR #18487: URL: https://github.com/apache/iotdb/pull/18487#issuecomment-5338738104
The idea is reasonable: flush pending tablets before reporting a parser failure so already-converted data isn’t lost. Two things need confirmation though: 1) In the synchronous pipe path, a non-success result is marked retryable by the caller, but this change clears the conversion context after flushing, so a retry can restart from the beginning and re-insert the same tablets; 2) this also affects ordinary LOAD, where a parser failure would now become partial write + error. Consider limiting the flush to receiver-owned/terminal tasks, or mark the task terminal after flushing, and add coverage for the managed path and for retries not duplicating writes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
