Caideyipi commented on code in PR #18465:
URL: https://github.com/apache/iotdb/pull/18465#discussion_r3841121555
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/DataNodeInternalRPCServiceImpl.java:
##########
@@ -1627,6 +1627,11 @@ public TPushConsumerGroupMetaResp
pushSingleConsumerGroupMeta(
@Override
public TPullCommitProgressResp pullCommitProgress(TPullCommitProgressReq
req) {
+ if (!SubscriptionConfig.getInstance().getSubscriptionEnabled()) {
+ return new TPullCommitProgressResp(new
TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode()))
+ .setCommitRegionProgress(Collections.emptyMap());
Review Comment:
Updated in commit 59a0df9a0ea6fe8c1c93e504eb7892012b5e2b32. When
subscription is disabled, pullCommitProgress, syncSubscriptionProgress, and
pushSubscriptionRuntime now return TSStatusCode.UNSUPPORTED_OPERATION; the pull
response still carries an empty progress map. The corresponding test
expectations were updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
