jt2594838 commented on code in PR #18376:
URL: https://github.com/apache/iotdb/pull/18376#discussion_r3842177106
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResourceManager.java:
##########
@@ -122,28 +122,39 @@ private File increaseFileReference(
segmentLock.lock(hardlinkOrCopiedFile);
try {
- resultFile =
- isTsFile
- ? FileUtils.createHardLink(source, hardlinkOrCopiedFile)
- : FileUtils.copyFile(source, hardlinkOrCopiedFile);
-
- // If the file is not a hardlink or copied file, and there is no related
hardlink or copied
- // file in pipe dir, create a hardlink or copy it to pipe dir, maintain
a reference count for
- // the hardlink or copied file, and return the hardlink or copied file.
- if (Objects.nonNull(pipeName)) {
- pipeNameToPipeTsFileDirPathMap.putIfAbsent(
- pipeName, hardlinkOrCopiedFile.getParentFile().getPath());
- hardlinkOrCopiedFileToPipeTsFileResourceMap
- .computeIfAbsent(pipeName, k -> new ConcurrentHashMap<>())
- .put(resultFile.getPath(), new PipeTsFileResource(resultFile));
+ final PipeTsFileResource existingResource =
+ getResourceMap(pipeName).get(hardlinkOrCopiedFile.getPath());
+ if (existingResource != null) {
+ existingResource.increaseReferenceCount();
+ resultFile = existingResource.getFile();
Review Comment:
The nullability is not checked before calling ` getResourceMap(pipeName)`,
is that ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
