hongzhi-gao commented on code in PR #18533:
URL: https://github.com/apache/iotdb/pull/18533#discussion_r3877503393
##########
iotdb-client/client-cpp/src/rpc/SessionImpl.h:
##########
@@ -145,7 +145,8 @@ class Session::Impl {
void handleRedirection(const std::string& deviceId, TEndPoint endPoint);
void handleRedirection(const std::shared_ptr<storage::IDeviceID>& deviceId,
TEndPoint endPoint);
- static void buildInsertTabletReq(TSInsertTabletReq& request, Tablet& tablet,
bool sorted);
+ // Returns false when all FIELD columns are null and the insert should be
skipped.
+ static bool buildInsertTabletReq(TSInsertTabletReq& request, Tablet& tablet,
bool sorted);
Review Comment:
// Returns false when filtering leaves no columns (tree-model all-null
FIELD tablet).
// Table-model inserts may keep TAG / ATTRIBUTE columns when all FIELD
columns are null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
