PDGGK commented on PR #18546:
URL: https://github.com/apache/iotdb/pull/18546#issuecomment-5496111186
One more data point on the convention, from the Edge tools added in #18552
on the
same day this branch was opened.
`scripts/tools/ops/daemon-edge.sh` and `scripts/tools/ops/destroy-edge.sh`
both
start with the same two lines:
```bash
IOTDB_HOME="${IOTDB_HOME:-$(cd "$(dirname "$0")"/../.. && pwd)}"
IOTDB_HOME="$(cd "$IOTDB_HOME" && pwd -P)"
```
That is: honour an `IOTDB_HOME` from the environment, then resolve it
physically.
`start-edge.sh` honours the environment too, via its `-z` guard.
So of the four Edge shell entry points, three take the value they are given
and
`stop-edge.sh` is the one that discards it — and the two ops scripts already
use
`pwd -P` for exactly the reason this pull request adds it. This is a smaller
change than it looked: it brings the fourth script into line with the other
three rather than introducing a new convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
