d-wang-commit opened a new pull request, #18596:
URL: https://github.com/apache/iotdb/pull/18596
Gracefully stopped nodes report their shutdown and are shown as Stopped
instead of Unknown: shutdown reports mark Stopped unless the node is Removing,
the heartbeat caches keep Stopped sticky against failure-driven Unknown while
still allowing revival by a live heartbeat, and every consumer that treats
Unknown as unavailable (region allocation candidates, region maintenance
retries, failed task transfers, subscription runtime sensitivity, fenced
filtering, removal safety checks, runtime writer selection) now treats Stopped
the same way.
## Why it's done this way
`Stopped` means "known, intentionally stopped" while `Unknown` means
"cannot tell why it is unreachable". The distinction only refines the displayed
diagnosis — every scheduling decision keeps treating
reaches the leader, heartbeat timeout still marks it `Unknown` (unchanged
fallback).
## Description
- New `NodeStatus.Stopped` value, treated as not readable (like `Unknown`).
- DataNode / ConfigNode shutdown hooks best-effort report their shutdown;
the leader marks the node `Stopped` unless it is `Removing` (Removing keeps the
highest priority). If the report never reaches the leader, heartbeat timeout
still marks it `Unknown`
(unchanged fallback).
- Heartbeat caches keep `Stopped` sticky: failure-driven or periodic
`Unknown` updates cannot refresh it, while a live heartbeat (e.g. after
restart) revives the node to `Running`.
- All consumers that treat `Unknown` as unavailable now treat `Stopped`
the same way: region allocation fallback candidates, failed-task region
transfer, region-maintenance short retries, subscription runtime sensitivity,
fenced DataNode filtering, removal safety
checks, and runtime writer selection.
## Tests
- **UT**: `NodeCacheTest` (sticky / revival / Removing priority for both
cache types); `ConfigManagerShutdownReportTest` (report marks Stopped, skips
Removing); `ProcedureManagerTest` (removal refusedwhen
related
node
is
Stopped); `RegionBalancerTest`; `RetryFailedTasksThreadTest`;
`RegionMaintainHandlerTest`; `SchemaUtilsTest`;
`SubscriptionRuntimeCoordinatorTest`; `ConfigNodeProcedureEnvTest` (Stopped
excluded from active
runtime
writers).
- **IT**: shutdown-hook and restart ITs (`IoTDBClusterNodeShutdownHookIT`,
`IoTDBClusterNodeErrorStartUpIT`); partition allocation ITs
(`IoTDBPartitionCreationIT`, `IoTDBPartitionDurableIT`, `Io - DataNode /
ConfigNode shutdown hooks best-effort report their shutdown; the leader marks
the node `Stopped` unless it is `Removing` (Removing keeps the highest
priority). If the report never reaches
the leader, heartbeat timeout still marks it `Unknown` (unchanged
fallback).
- Heartbeat caches keep `Stopped` sticky: failure-driven or periodic
`Unknown` updates cannot refresh it, while a live heartbeat (e.g. after
restart) revives the node to `Running`.
- All consumers that treat `Unknown` as unavailable now treat `Stopped`
the same way: region allocation fallback candidates, failed-task region
transfer, region-maintenance short retries, subscription
runtime sensitivity, fenced DataNode filtering, removal safety checks, and
runtime writer selection.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design
(or naming) decision point and compare the alternatives with the designs
that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen
designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development
mailing list),
link to that discussion from this PR description and explain what have
changed in your final design
compared to your original proposal or the consensus version in the end of
the discussion.
If something hasn't changed since the original discussion, you can omit a
detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for
the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items
apply to every PR. Remove the items which are not done or not relevant to
the PR. None of the items
from the checklist above are strictly necessary, but it would be very
helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes)
in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]