Caideyipi opened a new pull request, #18607:
URL: https://github.com/apache/iotdb/pull/18607

   ## Description
   
   Backports #18595 (`31e7534811217440172d3b2edd27170ef8328c19`) to `dev/1.3`.
   
   Pipe and Load conversion retries can restore failed measurements whose 
source type or value column is missing. Validate tablet column state before 
conversion so those measurements remain failed while valid columns still 
convert successfully.
   
   The production changes apply unchanged. The regression tests use the 1.3 
public `validateMeasurementSchema` entry point and TsFile API, and construct 
partial-insert failures through `markFailedMeasurement`.
   
   ## Validation
   
   - `mvn spotless:apply -pl iotdb-core/datanode`: passed.
   - `mvn test -pl iotdb-core/datanode -am 
-Dtest=PipeConvertedInsertTabletStatementTest 
-Dsurefire.failIfNoSpecifiedTests=false`: passed, all 26 reactor modules 
successful and all 3 regression tests passing.
   - Ran the same tests against the pre-backport converter classes: all 3 fail, 
reproducing out-of-bounds access in Pipe/Load and an incorrectly retained 
null-typed measurement.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added Javadocs for the non-trivial validation method.
   - [x] added unit tests covering Pipe and Load conversion of failed columns.
   
   <hr>
   
   ##### Key changed/added classes
   
   - `PipeConvertedInsertTabletStatement`
   - `LoadConvertedInsertTabletStatement`
   - `PipeConvertedInsertTabletStatementTest`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to