hongzhi-gao commented on code in PR #18601:
URL: https://github.com/apache/iotdb/pull/18601#discussion_r3974925366


##########
.github/workflows/multi-language-client.yml:
##########
@@ -198,9 +198,15 @@ jobs:
         # (was causing problems on windows, but could cause problem on linux, 
when updating the thrift module)
         run: |
           if [[ "${{ matrix.os }}" == "windows-2025-vs2026" ]]; then
-            ./mvnw clean verify -P with-cpp -pl iotdb-client/client-cpp -am 
-Dcmake.generator="Visual Studio 18 2026"
+            # The Windows standalone server scripts do not terminate reliably 
on hosted runners.
+            # Keep the Windows compile/link/package validation here; TLS/mTLS 
server ITs run on Unix.
+            ./mvnw clean verify -P with-cpp -pl iotdb-client/client-cpp -am 
-DskipTests -Diotdb.openssl.from.source=OFF -Dcmake.generator="Visual Studio 18 
2026"
+          elif [[ "${{ runner.os }}" == "Windows" ]]; then
+            # The Windows standalone server scripts do not terminate reliably 
on hosted runners.
+            # Keep the Windows compile/link/package validation here; TLS/mTLS 
server ITs run on Unix.
+            ./mvnw clean verify -P with-cpp -pl iotdb-client/client-cpp -am 
-DskipTests -Diotdb.openssl.from.source=OFF

Review Comment:
   Fixed. `-DskipTests` was removed from the Windows jobs, and the 
non-interactive launcher path now allows the plain/TLS/mTLS server phases to 
complete. macOS PR CI uses the default source-built OpenSSL path, exercising 
the relocation logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to