PDGGK opened a new pull request, #131:
URL: https://github.com/apache/iotdb-extras/pull/131

   # Fix the seventeen broken screenshots in the Grafana plugin README
   
   Every `<img>` in `connectors/grafana-plugin/README.md` is broken. All 
seventeen
   point into `apache/iotdb-bin-resources` under
   `docs/UserGuide/Ecosystem%20Integration/Grafana-plugin/`, and all seventeen
   return 404 — that tree no longer exists in that repository, whose `docs/`
   directory now contains only `IOTDB.png`.
   
   The screenshots themselves are not lost: the same files are still published 
with
   the Grafana plugin user guide on the website, so this repoints each `src` 
there
   rather than deleting the images. Sixteen keep their filename; the 
seventeenth is
   served as `add-empty-panel.png` rather than `add%20empty%20panel.png`.
   
   ## Why this location should not rot the same way
   
   The old links depended on `apache/iotdb-bin-resources`, a binary-asset
   repository, and broke when its `docs/` tree was removed wholesale. The new 
ones
   resolve to files that are version-controlled in `apache/iotdb-docs`, under
   `src/.vuepress/public/img/UserGuide/Ecosystem-Integration/Grafana-plugin/` —
   twenty-nine files, with the usual review process in front of them. The
   `iotdb.apache.org` URL is the published form of those tracked files, not a 
build
   artefact that happens to exist today.
   
   ## How this was checked
   
   Fetching every URL in the file after the change: all seventeen return
   `Content-Type: image/png`.
   
   Worth stating because it nearly fooled me: **the status code proves nothing
   here.** `iotdb.apache.org` answers unknown paths with `200` and an HTML error
   page, so a check on the status code alone reports every link as healthy —
   including a path I invented that has never existed. The negative control
   (`.../Grafana-plugin/DefinitelyNotAnImage.png` → `text/html`) is what makes 
the
   `image/png` result meaningful.
   
   No other file in this repository references `iotdb-bin-resources`, and the 
five
   non-image links in this README all resolve.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to