AlanDevise commented on issue #18633: URL: https://github.com/apache/iotdb/issues/18633#issuecomment-5673277939
Thanks for the analysis and the proposed fix. Here are my suggestions: **1. Make the isolation period configurable through the Builder, with a reasonable default.** The default configuration should provide endpoint isolation without requiring users to tune it, while allowing adjustments for different network environments. All sessions in the same pool should share the isolation state. Refreshing the node list should not clear an unexpired isolation period, otherwise a failed endpoint could re-enter the rotation prematurely. Once the period expires, allow a probe: clear the isolation on a successful connection, or renew it on failure. **2. Excluding `Unknown` nodes from `SHOW AVAILABLE URLS` can be addressed in a separate PR.** This involves server-side API semantics and compatibility with other clients, so it can be discussed independently without blocking the client-side fix. Even if the server filters out `Unknown` nodes, a node marked as `Running` may still be unreachable from the client. SDK-side isolation is therefore still necessary. **3. `SessionConnection.reconnect()` should skip endpoints whose isolation period has not expired. I suggest covering this in the same PR.** Otherwise, normal query endpoint selection would avoid a failed node, but reconnection would still attempt to connect to it and incur the timeout again. Query endpoint selection and reconnection should share the same isolation state. When all endpoints are isolated, retain a bounded recovery-probing mechanism with backoff, concurrency limits, and an overall timeout budget, rather than unconditionally retrying every failed endpoint. A controlled early probe could help detect recovery sooner, but each request should not independently retry the entire list of failed endpoints. Best wishes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
