Alchuang22-dev opened a new pull request, #18651:
URL: https://github.com/apache/iotdb/pull/18651
## Description
Add virtual directory browsing to the filesystem CLI, preserving upstream
command behavior and reusing its existing tree and table providers.
### Content
- Introduce `/.virtual` with model-specific views:
- Tree model: `by-database`, `by-measurement`, `by-tag`, and
`by-attribute`.
- Table model: `by-database` and `by-table`.
- Resolve virtual objects to canonical paths and delegate reads, schema,
metadata, statistics, and counts to upstream providers.
- Preserve SQL execution and ordinary filesystem paths through the virtual
directory wrapper.
- Align table listings with upstream by retaining `.csv` and `.meta` entries
and removing obsolete `.schema` entries.
- Add English and Chinese messages, resolver tests, and command
compatibility tests comparing canonical and virtual paths.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design
(or naming) decision point and compare the alternatives with the designs
that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen
designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development
mailing list),
link to that discussion from this PR description and explain what have
changed in your final design
compared to your original proposal or the consensus version in the end of
the discussion.
If something hasn't changed since the original discussion, you can omit a
detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for
the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
<hr>
### Test
- **391 CLI/FS tests passed**, including CLI entry points and virtual
directory compatibility:
```bash
mvn test -pl iotdb-client/cli
'-Dtest=org.apache.iotdb.cli.fs.**.*Test,CliFilesystemModeTest'
```
- **Full reactor compilation passed for both locales:**
```bash
mvn -ntp test-compile -DskipTests -Dxml-format.skip=true
mvn -ntp test-compile -DskipTests -P with-zh-locale -Dxml-format.skip=true
```
XML formatting was skipped because an unrelated, untracked diagram XML is
not well-formed. Stale `DirectoryChecker` build artifacts were moved aside
before verification.
- Spotless formatting, `git diff --check`, and English/Chinese message-key
and placeholder parity checks passed.
This PR has:
- [x] been self-reviewed.
- [x] concurrent read
- [x] concurrent write
- [x] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items
apply to every PR. Remove the items which are not done or not relevant to
the PR. None of the items
from the checklist above are strictly necessary, but it would be very
helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes)
in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]