CRZbulabula opened a new pull request, #18664:
URL: https://github.com/apache/iotdb/pull/18664

   ## Description
   
   A `RECONSTRUCT REGION 12,14,12,14 ON 7` request used to validate all four 
entries before submitting any procedure. The in-progress region-operation check 
therefore saw no procedure during validation, and the request submitted two 
independent Remove/Add state machines for each region. Concurrent 
reconstruction of the same replica can make an already-existing peer look like 
a successful Add.
   
   Deduplicate region IDs in insertion order at the ConfigNode submission 
boundary, as `MIGRATE REGION` already does. Each distinct region is checked and 
submitted once; the existing in-progress procedure check continues to reject 
conflicting requests. This change intentionally does not alter consensus retry 
idempotency or claim that a successful submission proves replica 
synchronization is complete.
   
   ## Tests
   
   - `ProcedureManagerReconstructRegionTest` verifies that `12,14,12,14` 
submits exactly two parent procedures in input order and that an active 
reconstruction blocks a subsequent request.
   - `mvn test -pl iotdb-core/confignode 
-Dtest=ProcedureManagerReconstructRegionTest,ProcedureManagerTest 
-DfailIfNoTests=false`
   - `mvn test -pl iotdb-core/confignode -P with-zh-locale 
-Dtest=ProcedureManagerReconstructRegionTest -DfailIfNoTests=false`
   
   ## Review checklist
   
   - [x] Self-reviewed the submission and concurrency path.
   - [x] Added unit coverage for duplicate IDs and an active conflicting 
procedure.
   - [x] Verified both English and Chinese locale builds for the focused test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to