Caideyipi commented on code in PR #18626:
URL: https://github.com/apache/iotdb/pull/18626#discussion_r4043430794
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableHeaderSchemaValidator.java:
##########
@@ -225,6 +231,12 @@ public Optional<TableSchema>
validateTableHeaderSchema4TsFile(
existingColumn = table.getColumnSchema(columnSchema.getName());
}
if (Objects.isNull(existingColumn)) {
+ if (preDeletedColumns == null) {
+ preDeletedColumns =
+ configTaskExecutor.getPreDeletedColumns(database,
tableSchema.getTableName());
+ }
Review Comment:
The result is cached for the full validation request in both INSERT and
TsFile paths, so multiple missing columns issue only one ConfigNode RPC; the
regression tests now cover both paths. I kept this cache request-scoped because
ConfigNode does not notify DataNode when DROP COLUMN commits, so a
cross-request cache could retain a stale deletion marker and reject a later
column recreation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]