Caideyipi opened a new pull request, #18675:
URL: https://github.com/apache/iotdb/pull/18675

   ## Description
   
   Fix a race in 
`SinkChannelFailurePropagationTest.testSingleChannelFailurePropagation`.
   
   `ShuffleSinkHandle.abort()` aborts its downstream channel before marking the 
handle itself as aborted. The test previously waited for the child 
`SinkChannel` to become aborted and then immediately asserted the parent 
`ShuffleSinkHandle` state, so the assertion could run inside that brief 
asynchronous gap.
   
   Wait for the parent handle state directly. Also give each asynchronous 
propagation phase its own timeout window instead of sharing one timestamp 
across the entire test.
   
   ## Testing
   
   - `mvn spotless:check -pl iotdb-core/datanode "-Ddevelocity.off=true"`
   - `mvn checkstyle:check -pl iotdb-core/datanode "-Ddevelocity.off=true"`
   - The targeted unit test was attempted locally, but the DataNode test 
compilation was blocked before test execution by stale generated sources and 
locally installed dependencies.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] modified an existing unit test to cover the asynchronous state 
transition.
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) 
in this PR
   
   - `SinkChannelFailurePropagationTest`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to