wangx0502 commented on code in PR #18603:
URL: https://github.com/apache/iotdb/pull/18603#discussion_r4052110669
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java:
##########
@@ -156,10 +156,17 @@ protected void remove(Set<Integer> nodeIds) throws
IoTDBException {
ConfigNodeMessages.THE_REMOVE_CONFIGNODE_SCRIPT_HAS_BEEN_DEPRECATED_PLEASE_CONNECT_TO,
-1);
}
+ /**
+ * Starts the ConfigNode services in dependency order.
+ *
+ * <p>The method must preserve the distinction between seed and non-seed
ConfigNodes and must
+ * start the RPC service only after the local services required to handle
requests are ready.
Review Comment:
Addressed in commit 36cc1b3ac4.
Updated the documentation to match the actual implementation.
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterManager.java:
##########
@@ -109,7 +116,12 @@ private void generateClusterId() {
}
}
- // TODO: Parallel test ConfigNode and DataNode
+ /**
+ * Tests connectivity from this ConfigNode to all registered ConfigNodes and
DataNodes and
Review Comment:
Addressed in commit 36cc1b3ac4.
Updated the documentation to match the actual implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]