shuwenwei commented on code in PR #18648:
URL: https://github.com/apache/iotdb/pull/18648#discussion_r4058771752
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/AuthorityChecker.java:
##########
@@ -131,13 +131,15 @@ public static IAuthorityFetcher getAuthorityFetcher() {
}
public static boolean invalidateCache(String username, String roleName) {
+ final boolean invalidated =
+ authorityFetcher.get().getAuthorCache().invalidateCache(username,
roleName);
Review Comment:
Respectfully, we are not going to fix the authority-cache refill race in
this PR. This PR is scoped to the table-level matcher cache change, while the
refill race originates in the pre-existing authority-cache / ConfigNode load
path and is independent of the modifications made here. Fixing it requires an
authority-cache generation/epoch redesign plus dedicated concurrency tests,
which is outside the objective of this PR.
We will keep this PR focused on the table-level matcher behavior and its
matcher-side invalidation ordering. If the maintainers consider the
authority-cache refill race mandatory for merge, it should be handled in a
separate PR.
The separate test concern about making the deduplication test fail without
the new table-level guard is addressed in d71c963c68.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]