Caideyipi opened a new pull request, #18695:
URL: https://github.com/apache/iotdb/pull/18695

   ## Description
   
   Subscription requests could exceed the negotiated Thrift frame size. This 
change:
   
   - Slices oversized subscription request bodies using the smaller 
client/server frame limit, with 1 KiB reserved for RPC and slice metadata. The 
receiver validates ordering, metadata and total length before reassembling, 
with a bounded reassembly size.
   - Batches heartbeat and commit contexts by serialized size, then merges the 
responses. Commit batches reserve headroom for echoed contexts and progress in 
the response.
   - Keeps handshake and close unsliced because they control the connection 
lifecycle; an oversized one fails locally instead of sending an invalid frame.
   - Leaves requests that fit in one frame unchanged. A server must support the 
new SLICE request type before a client can send oversized requests to it.
   
   ## Verification
   
   - Full reactor `mvn test-compile -DskipTests`, including `-P with-zh-locale`.
   - Targeted `PipeSubscribeSliceReqTest`, `SubscriptionProviderSlicingTest`, 
and `SubscriptionReceiverV1Test`: 26 tests passed.
   - Spotless, Checkstyle and `git diff --check` passed.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining non-obvious choices.
   - [x] added unit tests for the new paths.
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) 
in this PR
   
   `PipeSubscribeSliceReq`, `PipeSubscribeSliceReqBuilder`, 
`PipeSubscribeSliceReqHandler`, `AbstractSubscriptionProvider`, 
`SubscriptionReceiverV1`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to