JackieTien97 commented on code in PR #18692:
URL: https://github.com/apache/iotdb/pull/18692#discussion_r4118261849


##########
integration-test/src/test/java/org/apache/iotdb/relational/it/query/view/recent/IoTDBTableViewQueryIT.java:
##########
@@ -175,15 +175,16 @@ public void test() throws Exception {
           "select current from view1 where time > 1",
           "select current from table1 where time > 1" + (aligned ? "" : " and 
current is not null"),
           true);
+      // FILL runs before an outer ORDER BY, so give both sources the same 
ordered input.
       compareQueryResults(
           session,
-          "select * from view1 fill method linear",
-          "select * from table1 fill method linear",
+          "select * from (select * from view1 order by time, battery) fill 
method linear",
+          "select * from (select * from table1 order by time, battery) fill 
method linear",

Review Comment:
   ```suggestion
             "select * from (select * from view1 order by battery, time) fill 
method linear",
             "select * from (select * from table1 order by battery, time) fill 
method linear",
   ```



##########
integration-test/src/test/java/org/apache/iotdb/relational/it/query/view/recent/IoTDBTableViewQueryIT.java:
##########
@@ -175,15 +175,16 @@ public void test() throws Exception {
           "select current from view1 where time > 1",
           "select current from table1 where time > 1" + (aligned ? "" : " and 
current is not null"),
           true);
+      // FILL runs before an outer ORDER BY, so give both sources the same 
ordered input.
       compareQueryResults(
           session,
-          "select * from view1 fill method linear",
-          "select * from table1 fill method linear",
+          "select * from (select * from view1 order by time, battery) fill 
method linear",
+          "select * from (select * from table1 order by time, battery) fill 
method linear",
           true);
       compareQueryResults(
           session,
-          "select * from view1 fill method previous",
-          "select * from table1 fill method previous",
+          "select * from (select * from view1 order by time, battery) fill 
method previous",
+          "select * from (select * from table1 order by time, battery) fill 
method previous",

Review Comment:
   ```suggestion
             "select * from (select * from view1 order by battery, time) fill 
method previous",
             "select * from (select * from table1 order by battery, time) fill 
method previous",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to