Copilot commented on code in PR #18793:
URL: https://github.com/apache/iotdb/pull/18793#discussion_r4196241958
##########
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/TElasticFramedTransport.java:
##########
@@ -322,6 +326,11 @@ public void checkReadBytesAvailable(long numBytes) throws
TTransportException {
}
}
+ @Override
+ public void resetMessageSizeAndConsumedBytes(long newSize) throws
TTransportException {
+ underlying.resetMessageSizeAndConsumedBytes(newSize);
Review Comment:
The new frame-sized reset does not constrain protocol allocations.
`TBinaryProtocol` calls this outer transport's `checkReadBytesAvailable`, but
that override only compares against `thriftMaxFrameSize` and never consults the
underlying budget reset here. A small frame can therefore still declare a very
large string/binary value below the global maximum, causing that array to be
allocated before the read fails. Delegate the availability check to the reset
underlying transport (or validate against the current read-buffer remainder),
and add a malformed-frame regression test like Thrift 0.25's frame-bound-budget
test.
##########
.github/workflows/multi-language-client.yml:
##########
@@ -108,7 +110,7 @@ jobs:
fail-fast: false
max-parallel: 15
matrix:
- os: [ubuntu-22.04, ubuntu-24.04, windows-2022, windows-2025-vs2026,
macos-latest]
+ os: [ubuntu-22.04, ubuntu-24.04, ubuntu-22.04-arm, windows-2022,
windows-2025-vs2026, macos-latest]
Review Comment:
`ubuntu-22.04-arm` entered GitHub-hosted runner deprecation on September 17,
2026 and is now subject to intentional brownouts before retirement. Adding it
to this required matrix makes client CI intermittently fail for infrastructure
reasons; use the supported `ubuntu-24.04-arm` image instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]