Caideyipi opened a new pull request, #18815:
URL: https://github.com/apache/iotdb/pull/18815

   ## Description
   
   Validate length-prefixed Pipe strings and binary payloads against the 
remaining request body before decoding V1/V2 handshakes, slices, and 
receiver-runtime cleanup requests. Also reject V2 handshake parameter counts 
that cannot fit in the body. Malformed payloads now return the existing 
`PIPE_ERROR` response, including through compressed wrappers.
   
   Valid wire encoding, null/empty strings, and handshake buffer positions 
remain compatible.
   
   ## Validation
   
   - All 77 tests passed across `PipeTransferRequestValidationTest`, 
`PipeTransferSliceReqBuilderTest`, `PipeTransferCompressedReqTest`, 
`PipeDataNodeThriftRequestTest`, and `PipeReceiverTest`.
   - Full English reactor build and targeted tests:
     ```text
     mvn -o test 
-Dtest=PipeTransferRequestValidationTest,PipeTransferSliceReqBuilderTest,PipeTransferCompressedReqTest,PipeDataNodeThriftRequestTest,PipeReceiverTest
 -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.build.cache.enabled=false
     ```
   - Full Chinese reactor compilation:
     ```text
     mvn -o test-compile -P with-zh-locale -DskipTests 
-Dmaven.build.cache.enabled=false
     ```
   - Spotless and Checkstyle passed. Both reactor builds used 
`MAVEN_OPTS=-Xmx2g`.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added comments explaining the allocation checks.
   - [x] added parser and receiver regression tests.
   
   ##### Key changed/added classes
   
   `PipeTransferPayloadReader`, `PipeTransferHandshakeV1Req`, 
`PipeTransferHandshakeV2Req`, `PipeTransferSliceReq`, and 
`PipeTransferPipeReceiverRuntimeInfoCleanupReq`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to