CritasWang commented on PR #138:
URL: https://github.com/apache/iotdb-extras/pull/138#issuecomment-6143478023

   Reviewed the notes against the tree at `2bd53be`. Coverage looks right: 
every master PR in the range (`#82`–`#84`, `#89`, `#93`, `#94`, `#109`–`#137`) 
is referenced, and the exclusions you listed (#80, #86, #107) match what 
merged. Most of the claims check out. A few items need fixing before this can 
serve as the release body.
   
   ### Needs fixing
   
   1. **The version in the title does not match the repository.** The notes are 
headed `Apache IoTDB Extras 2.0.11`, but `pom.xml` is `2.0.4-SNAPSHOT` and the 
only tag, `v2.0.3`, carries `<version>2.0.3</version>`. `README.md` states: 
"Extras keeps its own artifact version (`2.0.4-SNAPSHOT`). The dependency 
baseline is the released IoTDB `v2.0.11` tag." So this release is **2.0.4**, 
with IoTDB 2.0.11 as its dependency baseline. If the intent is to make Extras 
track the IoTDB version, that is a separate change touching the poms, the 
README and the distribution names -- please don't let the release notes decide 
it by themselves.
   
   2. **`#85` is credited with a change it did not make.**
   
      > Spring Boot starter: `IoTDBSessionPool` becomes an auto-configuration 
whose pool beans close with the context. (#85, #132)
   
      
`META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports`
 has registered `IoTDBSessionPool` since #46 (`065ec4d`), and it was already 
registered at `#132^`. Both before and after #85 (`54ca77d`) the class is 
`@Configuration` with plain `@Bean` methods; `@AutoConfiguration` together with 
`@Bean(destroyMethod = "close")` arrives with #132 (`404a4bf`). That line 
should cite **#132 only**. #85 changed the example poms and the starter pom's 
dependency versions.
   
   3. **The Zeppelin bullet has no reference.** It is the only bullet without a 
PR number. The actual change is `166d75d` and `827ccea` ("zeppelin defalut 
jar-with-dependencies", 2025-09-23/24), pushed directly to master without a PR. 
Please cite those commits. (The statement itself is accurate: 
`maven-assembly-plugin` binds `single` to `package` with 
`jar-with-dependencies`.)
   
   4. **The `us`/`ns` DELETE limitation has no source.** As written, a reader 
cannot verify it from the repository: there is no in-tree document describing 
it (`git log --all -- docs` is empty on master, and the branch used for the 
2.0.11 alignment has no `docs/` either). If there is an upstream IoTDB issue or 
JIRA, please link it; otherwise the reproduction notes need to land in the 
repository alongside these notes.
   
   5. **`#82` does not cover what it is cited for.** `#82` ("add readme") only 
touches `README.md`, `README-zh.md`, `examples/*/pom.xml` and the root 
`pom.xml`. It does not contain the Kafka/RocketMQ/RabbitMQ table-model examples 
(that is #93) or the MyBatis-Plus update (that is #83). Suggest `(#83, #93, 
#132)` for that bullet.
   
   ### Suggested additions
   
   - **Spring Boot 4.** The starter carries a `spring-boot4` profile 
(`iotdb-spring-boot-starter/pom.xml`, Spring Framework 7.0.9), and CI runs 
dedicated Spring Boot 4 jobs for the starter and the MyBatis-Plus example. That 
is user-visible compatibility information and deserves a line under 
*Compatibility*.
   - **MyBatis needs a registration step.** Beyond the type mapping, 
`mybatis-support/README.md` documents that on the 2.0.11 JDBC driver a 
table-model prepared SELECT returns `true` from `execute()` without populating 
`getResultSet()`, so applications have to register `IoTDBQueryInterceptor`. The 
`with-mybatis` distribution profile also ships that jar next to the generator 
plugin now.
   - **Baseline, date and links.** Please state the baseline ("since v2.0.3") 
and a release date, and link the PR numbers rather than leaving them as bare 
`(#132)` text. With no GitHub releases in this repository, this file is likely 
to be the release body and the vote email, where links are considerably easier 
to use than numbers.
   - **Worth closing in the same PR:** `connectors/grafana-plugin/CHANGELOG.md` 
says it "previously pointed at `../RELEASE_NOTES.md`, which does not exist in 
this repository". From that file's location `../` resolves to `connectors/`, so 
adding the file at the repository root leaves the fix one directory short -- 
`../../RELEASE_NOTES.md` would close the loop.
   
   The remaining bullets I checked and they hold: JDK 17 / IoTDB 2.0.11 / 
TsFile 2.4.0 with the JDK 8 and 11 profiles removed; starter `fetch-size` 5000 
(was 1024), `connection-timeout-in-ms` 0 and deprecated `sql-dialect`; Grafana 
>= 12.3.0; ThingsBoard v4.3.1.2; metric-scrape with Docker and Kubernetes 
examples; Range/Instant/Both query types and the multi-value `prefixPath` 
expansion; the Flink multi-node URLs and lookup-join fix; and Spark 2.4 / Scala 
2.11 as compile-only with a runtime migration pending.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to