ColinLeeo opened a new issue, #18862:
URL: https://github.com/apache/iotdb/issues/18862

   ### Description
   
   PR #18826 shares `appendCommonExpressionColumns()` between query filtering 
and schema attribute updates. The helper currently lives as a public static 
method on `FilterAndProjectOperator` and embeds its `satisfy()` filter 
semantics, coupling schema code to a query operator implementation.
   
   The helper also has lifecycle effects beyond appending to a Java list: it 
may evaluate an uncached transformer with a row-selection mask, replace 
descendant caches through selection evaluation, and call `getColumn()` on each 
common expression, consuming reference counts and possibly releasing cached 
columns. Existing cached columns are reused; the helper does not 
unconditionally reset the DAG.
   
   ### Follow-up scope
   
   Move common-column materialization into an appropriately scoped calc 
utility/service with an explicit contract for:
   
   - original input row indexes and full-length masked columns;
   - false/NULL filter results and zero matching rows;
   - cached-result reuse, evaluation, and reference-count consumption;
   - shared use by query operators and schema UPDATE;
   - allocation/scanning costs when common expressions are present.
   
   Keep the guarded-cast and real non-leaf common-expression regression 
coverage from PR #18826. Decoupling the helper should not alter short-circuit 
behavior, cache ownership, or the filtered column layout. Documentation 
clarifying the existing side effects can be improved independently of this 
extraction.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to