Caideyipi opened a new pull request, #18876:
URL: https://github.com/apache/iotdb/pull/18876

   ## Description
   
   Subscription events currently share the server-wide recycle timeout, which 
defaults to 600 seconds. Add the topic attribute 
`recycle-uncommitted-event-interval-ms` so each topic can override this timeout 
with a positive long value in milliseconds. Topics without the attribute 
continue to use `subscription_recycle_uncommitted_event_interval_ms`.
   
   The attribute supports CREATE TOPIC and ALTER TOPIC across topic modes and 
response formats. Both Pipe and Consensus subscription queues apply updates to 
existing in-flight events, and Consensus queues wake when the setting changes. 
Runtime overrides are isolated by topic name and data model; metadata snapshot 
updates preserve existing overrides while they are being applied.
   
   ```sql
   CREATE TOPIC t WITH ('recycle-uncommitted-event-interval-ms'='1200000');
   ALTER TOPIC t WITH ('recycle-uncommitted-event-interval-ms'='300000');
   ```
   
   ### Validation
   
   - Focused unit tests cover parsing, CREATE/ALTER validation, fallback, 
metadata updates, tree/table isolation, and timeout redelivery in Pipe V1/V2 
and Consensus queues.
   - Full-reactor English build with 60 focused unit tests passing.
   - Full-reactor Chinese compilation: `mvn -nsu test-compile -DskipTests -P 
with-zh-locale`.
   - Spotless and `git diff --check`.
   
   This PR has:
   
   - [x] been self-reviewed, including concurrent reads and metadata updates.
   - [x] added documentation for the topic attribute and the server fallback.
   - [x] added comments explaining runtime configuration access and snapshot 
handling.
   - [x] added or updated unit tests for the new behavior.
   
   ##### Key changed classes
   
   `TopicConfig`, `SubscriptionInfo`, `SubscriptionTopicAgent`, 
`SubscriptionPrefetchingQueue`, `ConsensusPrefetchingQueue`, and 
`SubscriptionEvent`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to