hongzhi-gao commented on code in PR #18878:
URL: https://github.com/apache/iotdb/pull/18878#discussion_r4279761181


##########
iotdb-client/odbc/licenses/GPL-3.0.txt:
##########
@@ -0,0 +1,674 @@
+                    GNU GENERAL PUBLIC LICENSE

Review Comment:
   Addressed in 6105f5afd7d. Removed both committed license texts 
(`GPL-3.0.txt` and `GCC-Runtime-Exception.txt`) and their RAT exclusion. 
Windows/MSVC packages now contain neither file.
   
   For GNU/Linux convenience binaries, the driver combines libstdc++/libgcc 
runtime object code into the shared library. ASF has a specific [GCC Runtime 
Library exception 
policy](https://www.apache.org/legal/resolved.html#gcc-runtime-library) 
covering this combination; the README now explicitly documents the inclusion 
and the required PMC review. The two upstream notices are obtained only during 
GNU/Linux install/packaging, checked against pinned SHA-256 hashes, and 
included in the binary package with a LICENSE disclosure. No GCC runtime 
sources or GPL license texts are vendored in our source tree.
   
   Verified: RAT passes for both client/ODBC modules without the exclusion; 
Windows CTest 4/4 and CPack pass; the Windows ZIP contains no GCC/GPL notices; 
offline notice packaging accepts the verified files and rejects a modified 
file. Local manylinux packaging now also passes: CTest 4/4, GLIBC <= 2.28 and 
dependency checks, CPack, and inspection of the actual ZIP for both runtime 
notices and the binary LICENSE disclosure. [Current fork 
CI](https://github.com/hongzhi-gao/iotdb/actions/runs/38692141946) and the 
[upstream PR ODBC 
workflow](https://github.com/apache/iotdb/actions/runs/38692146862) now both 
pass all eight jobs for 6105f5afd7d, including Windows/Linux extracted-package 
real-server TLS/mTLS and Windows .NET/ADO consumer tests.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to