ColinLeeo commented on code in PR #18869:
URL: https://github.com/apache/iotdb/pull/18869#discussion_r4279867830


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemorySide.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.execution.memory;
+
+/** The exchange budget charged by a registered plan node. */
+public enum MemorySide {
+  INPUT,
+  OUTPUT;
+
+  public long getMaxBytes(long fragmentExchangeMaxBytes) {
+    long inputMaxBytes = fragmentExchangeMaxBytes / 2;
+    return this == INPUT ? inputMaxBytes : fragmentExchangeMaxBytes - 
inputMaxBytes;

Review Comment:
   Follow-up in 99bfeb4c0702024f38307f68702610c909fdd86f: the budget API now 
takes the actual INPUT/OUTPUT presence explicitly. An eligible FI with only one 
charged direction receives the full F; the F/2 split applies only when both 
directions are present. Only active directions are checked against the maximum 
TsBlock size. Local inputs do not count as receiver-side INPUT because their 
queues are charged to the producing FI.
   
   Added tests for input-only and output-only Collect with B = F, a full-F 
single-block reservation for each direction, odd bidirectional budgets, and 
local/mixed input ownership. Non-eligible FIs keep the original independent 
quotas and the existing dependency exclusions remain unchanged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to