hongzhi-gao commented on PR #18888:
URL: https://github.com/apache/iotdb/pull/18888#issuecomment-6187923544

   I reviewed the change at ccd15fcb81. Moving the manual-flush takeover into 
the flush-time callback lets `asyncClose()` pass its guard and queue the 
working memtable before `FlushManager` registration. The affected tests then 
flush explicitly and check the deletion WAL entries and persisted modification. 
I found no blocking issue in the test change.
   
   `git diff --check upstream/master...pr/18888` passed. I attempted the three 
affected test methods in an isolated worktree, but compilation stopped before 
tests ran because locally installed cross-module artifacts are older than this 
checkout (missing generated Thrift and grammar symbols). The DataNode unit-test 
CI jobs are still running; please use their result as the test gate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to