Caideyipi opened a new pull request, #18896:
URL: https://github.com/apache/iotdb/pull/18896

   ## Description
   
   Queued IoTConsensus requests can pass the RPC read-only check before 
shutdown and apply after storage or WAL has stopped, reopening processors and 
WAL nodes. This backport closes write admission and drains admitted writes, 
including their WAL separators, before the final flush and storage shutdown.
   
   Cherry-picks:
   
   - 532d6c13addc04946535729db388fb4c18feb6b9 (#18841)
   - d2b97bc8455710a4540df03a1f15192d276629f2 (#18893)
   
   ### Adaptation for dev/1.3
   
   - Reuse `DataRegion.insertLock` for admission and WAL separators, keeping 
memory backpressure and retry waits outside the lock. Apply the same fencing to 
tree deletions, which already hold the outer visitor lock in 1.3.
   - Adapt the 1.3 multi-tablet implementation so the complete admitted batch 
finishes under the write lock with one WAL separator. Add a regression test for 
shutdown between tablets.
   - Use the 1.3 request, state-machine, and status APIs. Preserve its 
independent per-request SyncLog status handling.
   - Backport the tree-model replication check to 
`pipe.it.autocreate.IoTDBPipeClusterIT`. Table-model code and tests do not 
apply to 1.3.
   
   ## Validation
   
   - Spotless formatting passed for consensus, datanode, and integration-test.
   - Reactor build and targeted tests: `mvn -B -nsu test -pl 
iotdb-core/datanode -am 
-Dtest=IoTConsensusServerImplTest,IoTConsensusShutdownTest,DataRegionStateMachineTest,DataRegionTest
 -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false -DforkCount=1`.
   - Coverage includes queued writes, the pre-apply race, draining admitted 
writes and separators, retry waits, memory backpressure, all 1.3 write paths 
after stop, other consensus protocols, and WAL checkpoint recovery.
   - Cluster integration tests were not run locally.
   
   This PR has:
   
   - [x] been self-reviewed, including concurrent writes and shutdown.
   - [x] added and adapted regression tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to