hongzhi-gao commented on PR #18899: URL: https://github.com/apache/iotdb/pull/18899#issuecomment-6208208824
<!-- iotdb-ai-radar-review:review-apache-iotdb-18899-f15d24542935966c450f99b67bcdcb5de1bcf3ff --> **Automated preliminary correctness review** (Codex CLI, based on PR head `f15d24542935`). **No tests were run**. 1. [integration-test/src/test/java/org/apache/iotdb/db/it/utils/TestUtils.java:2088](https://github.com/apache/iotdb/blob/f15d24542935966c450f99b67bcdcb5de1bcf3ff/integration-test/src/test/java/org/apache/iotdb/db/it/utils/TestUtils.java#L2088) - **Trigger:** IoTDBPipeMetaIT.testAttributeSync reaches assertDataAlwaysOnEnv before the newly created pipe has transferred the sender's attributes. - **Potential issue:** The restored fail-fast assertion queries immediately and rejects the first mismatch. testAttributeSync initializes receiver attributes as (1,1,null) and (2,2,null), creates the pipe on the sender, then immediately expects merged attributes (1,1,1) and (2,2,2). There is no receiver convergence wait. A valid asynchronous transfer can therefore fail this test before replication completes. Wait for the merged attributes with assertDataEventuallyOnEnv before asserting their continued stability. This review is AI-assisted and not an approval or request for changes. Please verify each scenario before acting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
