hongzhi-gao commented on PR #17609:
URL: https://github.com/apache/iotdb/pull/17609#issuecomment-6208481098

   1. 
[iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java:628](https://github.com/apache/iotdb/blob/03b8d95a299c0ca082e73357b9633e121b289a27/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java#L628)
      - **Trigger:** The WAL write completes, but simpleLogWriter.force() 
throws.
      - **Potential issue:** The catch returns failure without truncating the 
appended record or disabling further writes. write() then skips execution. A 
later successful force can persist that record, and startup replays it despite 
its never having been applied during normal operation. Subsequent plans can 
therefore execute against different metadata before and after restart. The 
captured pre-write offset should also protect persistence-failure paths.
   
   2. 
[iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java:670](https://github.com/apache/iotdb/blob/03b8d95a299c0ca082e73357b9633e121b289a27/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java#L670)
      - **Trigger:** Log rotation successfully closes the writer, then 
Files.move throws an IOException.
      - **Potential issue:** closeSimpleLogWriter sets the writer to null 
before the rename. The exception returns through the persistence failure 
handler without reopening the original file. Every subsequent write fails the 
initialization check, so even a transient rename failure permanently prevents 
metadata writes until restart.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to