Caideyipi opened a new pull request, #18922:
URL: https://github.com/apache/iotdb/pull/18922

   ## Description
   
   Backport the ConfigNode fix from #18913 
(`4943c730d7aac7612b6a5c700625e94628a970cb`) to `dev/1.3`.
   
   When `STOP PIPE` finishes while a ConfigNode subtask is waiting in 
`extractor.supply()`, the subtask can still transfer the returned event. Check 
the stop flag before polling and again after polling returns. Retain the 
fetched event for restart, and release it without committing if the task was 
dropped during polling.
   
   Adapt the regression tests to the 1.3 field names, `extractor` and 
`outputPipeConnector`.
   
   ### Backport scope
   
   The LOAD retention changes from #18913 do not apply to this branch. In 
`dev/1.3`, `LoadTsFileDispatcherImpl` sends pieces and terminal commands 
directly to every replica. The branch does not contain 
`LoadTsFileConsensusNode`, `LoadTaskRetention`, or `LoadTsFileCleaner`, or the 
staged-payload WAL references addressed by the original fix.
   
   ## Validation
   
   - All three new regression tests fail against the original `dev/1.3` 
implementation.
   - With the fix, `PipeConfigNodeSubtaskTest` and 
`PipeConfigNodeSubtaskExecutorTest` pass: 8 tests, no failures or errors. 
Dependencies, including Thrift sources, are built from this branch using the 
reactor.
   - Spotless, Checkstyle, and `git diff --check` pass.
   
   ```text
   mvn -B -nsu test -pl iotdb-core/confignode -am 
-Dtest=PipeConfigNodeSubtaskTest,PipeConfigNodeSubtaskExecutorTest 
-Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false
   ```
   
   This PR has:
   
   - [x] been self-reviewed, including concurrent polling, stop, and close 
behavior.
   - [x] added deterministic unit tests for stop, restart, and drop during 
polling.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to