JackieTien97 commented on issue #18846:
URL: https://github.com/apache/iotdb/issues/18846#issuecomment-6304311906

   Thanks for the corrected definition. I agree with keeping this fix focused 
on constructor parity with IoTDBStatement: forward charset, the response’s 
tableModel flag, and columnIndex2TsBlockColumnIndexList so that valid result 
columns return the correct values.
   Please cover reordered columns, repeated projections/aliases, and an 
identity-mapping control. Assert actual values through both index-based and 
name-based getters, with Statement as a reference. Use mocked-RPC tests to 
guarantee these mapping cases, plus real-server integration coverage.
   
   Two details need adjustment:
   1. Make any defensive copy null-safe. new 
ArrayList<>(resp.getColumnIndex2TsBlockColumnIndexList()) throws when the 
mapping is absent, preventing the existing fallback in IoTDBRpcDataSet. 
Preserve that behavior and add a missing-mapping regression case.
   2. TIMESTAMP is valid as a table-model field. The existing 
testPreparedStatementWithAllDataTypes defines and reads a TIMESTAMP FIELD. 
Please remove the statement excluding it from mapped value columns and include 
timestamp projection coverage.
   
   Invalid column ordinals/names returning SQLException is a separate 
JDBC-conformance issue and should not gate this fix. The reported bounds 
exception occurs while reading a valid logical column with the wrong physical 
mapping; correcting the mapping should resolve it, rather than merely changing 
the exception type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to