Caideyipi commented on PR #18828: URL: https://github.com/apache/iotdb/pull/18828#issuecomment-6310013405
Applied the remaining review feedback in `240cfd502cce`: - Worker exceptions are handled per file in both queues, so a failed CSV batch no longer skips the files behind it. SQL statement/read failures and whole-file CSV rejections now fail the run and update file counts. - `import-tsfile` now shares the collision-safe TsFile/sidecar operations with `import-data`. Both success and failure archives preserve relative directories, reject occupied main/sidecar targets before moving the group, and propagate archival errors to the processing result. - Fixed return-code propagation in `export-tsfile.bat`, `schema/export-schema.bat`, and `schema/import-schema.bat`. - Documented table SQL/TsFile custom-query limitations in both locales, grouped the new message constants before the constructor, and restored result-row counting for non-aligned tree SQL export progress. Validation: Spotless and CLI Checkstyle passed. `mvn -o test -pl iotdb-client/cli -Dtest=DataToolRegressionTest,ImportTsFileOperationTest,WriteDataFileTest` passed all 31 tests, and the same command with `-P with-zh-locale` also passed all 31. These runs used the declared TsFile `2.4.1-260915-SNAPSHOT`. The 51 English/Chinese message keys and format specifiers match. All five Windows launchers touched by this PR correctly returned a Java probe's exit code 7 despite a caller-side `ret_code=91`. Full-reactor `mvn -o test-compile -DskipTests` and `mvn -o test-compile -DskipTests -P with-zh-locale` both passed all 53 modules, with Maven capped at a 1 GB heap. No live-cluster integration tests were run. Review threads are left open for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
