hongzhi-gao opened a new pull request, #18968:
URL: https://github.com/apache/iotdb/pull/18968

   ## Description
   
   Fix macOS C++ dependency builds where Homebrew exposes Boost through a 
shared include directory. Thrift can then load the OpenSSL headers from that 
directory before the headers matching the libraries found by CMake, as seen in 
the [failed check on 
#18952](https://github.com/apache/iotdb/actions/runs/39541561442/job/119073421915?pr=18952).
   
   Resolve the Boost header symlink before setting `BOOST_INCLUDE_DIR`, so 
Homebrew uses the Boost-specific Cellar include directory. Upgrade the C++ 
Thrift compiler and runtime together from 0.24.0 to 0.25.0 and update 
dependency documentation.
   
   Thrift 0.25.0 generates `vector<bool>::emplace_back()`, which requires C++17 
with libc++. Compile only `iotdb_session` as C++17; keep public consumers and 
examples at C++11. Use private `WIN32_LEAN_AND_MEAN` for the library to avoid 
the Windows RPC `byte` typedef conflicting with `std::byte`. Add Boost 
path-resolution regression coverage and an installed-SDK consumer check using 
C++11.
   
   ## Validation
   
   - [Unmodified Multi-Language Client 
workflow](https://github.com/hongzhi-gao/iotdb/actions/runs/39576870361): all 
six C++ platforms, Go and Python passed. C++ validation includes the server 
build, ordinary tests, TLS, mTLS and the installed-SDK consumer.
   - [Full package 
matrix](https://github.com/hongzhi-gao/iotdb/actions/runs/39576875527): Linux 
x86_64/aarch64 with the glibc 2.28 baseline, macOS x86_64/arm64, and Windows VS 
2017/2019/2022 passed, including unpacked examples against a real server. The 
VS 2026 job built the package and examples, then hit a Maven Central HTTP 502 
while downloading the server's ANTLR plugin.
   - [Unmodified VS 2026 packaging retry on the same 
commit](https://github.com/hongzhi-gao/iotdb/actions/runs/39580607005): passed, 
including unpacked examples against a real server.
   - [Original #18952 head plus this patch, 
macOS](https://github.com/hongzhi-gao/iotdb/actions/runs/39577235895): passed; 
ordinary tests 5/5, TLS 1/1, mTLS 1/1 and C++11 consumer 1/1.
   - Downloaded all eight package variants and verified SHA-512 checksums and 
Thrift 0.25.0 dependency metadata. Linux glibc baseline checks passed.
   - Boost path regression passes with the fix; the old resolution reproduces 
the header mismatch. Spotless, clang-format 17 and `git diff --check` passed.
   
   The default bundled OpenSSL remains 3.5.8. These checks do not claim OpenSSL 
4 runtime validation.
   
   This PR has:
   - [x] been self-reviewed and independently reviewed.
   - [x] updated dependency and compiler-requirement documentation.
   - [x] added regression and installed-package consumer checks.
   - [x] been tested against real IoTDB servers.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to