hongzhi-gao opened a new pull request, #18979:
URL: https://github.com/apache/iotdb/pull/18979

   ## Description
   
   Invalid values such as `storage_engine_memory_proportion=0:10` or 
`write_memory_proportion=0:1` previously returned before storage memory 
managers were initialized, causing startup to fail when those managers were 
accessed. Malformed values could also fail during parsing.
   
   Validate each setting independently as exactly two positive 32-bit integers. 
Invalid values now emit the existing localized warning and use the documented 
defaults (8:2 and 19:1), allowing manager initialization to complete. Derive 
memtable and time-partition budgets from the resolved write budget, and avoid 
overflow in proportion sums and memory-share calculations while preserving 
integer truncation.
   
   ## Validation
   
   - `mvn spotless:apply -o -pl iotdb-core/datanode -Ddevelocity.off=true`
   - `git diff --check`
   - `mvn test -o -pl iotdb-core/datanode -am -Dtest=DataNodeMemoryConfigTest 
-Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false 
-Ddevelocity.off=true`: 15 tests passed; also passed with `-P with-zh-locale`.
   - `mvn test-compile -o -DskipTests -Ddevelocity.off=true`: full 53-module 
reactor compilation passed; also passed with `-P with-zh-locale`.
   - Compiling the baseline `DataNodeMemoryConfig` and running the same tests 
with JUnitCore produces three regression failures, covering invalid-input 
initialization, independently configured write proportions, and 
large-proportion overflow.
   - No live-node startup integration test was run.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining non-obvious arithmetic.
   - [x] added unit tests covering the changed behavior.
   
   ##### Key changed classes
   
   - `DataNodeMemoryConfig`
   - `DataNodeMemoryConfigTest`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to