Caideyipi commented on PR #18986:
URL: https://github.com/apache/iotdb/pull/18986#issuecomment-6337505872

   @CritasWang Thanks for the detailed review and the 1.3 compatibility checks. 
Applied the changes in 9b05f39e394 and 4461d6704c7:
   
   1. **Completion messages:** failed imports no longer print `Import 
completely!`. The asynchronous summary also checks for unprocessed files and 
interruption; the synchronous CSV/SQL paths suppress success messages after 
failures.
   2. **Connection retries:** per-record fallback now happens only after 
`StatementExecutionException`. An exhausted `SessionPool` batch makes 4 insert 
calls, independent of its row count, and its original rows are saved once. If a 
connection failure occurs during row recovery, the remaining records are saved 
without further row retries. Repeated row error messages are suppressed; the 
initial batch error is still reported.
   3. **Conversion errors:** the exit-code change was unintended for this 
backport. Restored the existing 1.3/master behavior: an unconvertible value 
writes the original row to `.failed_0` but does not alone make the run exit 
with 1. Added a regression test against the asynchronous entry point.
   4. **Windows launchers:** fixed all five existing wrappers to use `ENDLOCAL 
& EXIT /B %ret_code%` and corrected the PR description. Tested each on Windows 
with a Java exit-code fixture and a caller's `ret_code=73`; both Java exit 
codes 0 and 7 propagate correctly.
   5. **CLI `import`:** the synchronous path now resets and reads the failure 
flag and returns `CODE_ERROR` for CSV insertion or SQL statement failures. 
Tests cover failure followed by a successful command, so a previous failure 
does not leak into the next invocation.
   
   Also removed the duplicate TsFile operation enum/adapter, retained only 
original CSV record references in the batch context, and added coverage across 
`Session`/`SessionPool`, time/device layouts, and aligned/non-aligned inserts. 
The group-processing helpers and I/O exception documentation also address the 
Sonar findings on the removed enum.
   
   Validation: a clean CLI build passed all **65 unit tests**, with **0 
Spotless/Checkstyle violations**. The **10 Windows launcher checks** passed as 
well.
   
   ```powershell
   mvn -o spotless:apply -pl iotdb-client/cli
   mvn -o -pl iotdb-client/cli '-Dmaven.build.cache.enabled=false' 
'-Ddevelocity.off=true' clean test
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to