luoluoyuyu opened a new pull request, #18989: URL: https://github.com/apache/iotdb/pull/18989
## Root cause `ConfigNode` compared the raw value of `data_region_consensus_protocol_class` with `ConsensusFactory.IOT_CONSENSUS_V2`, while `DataNode` normalizes the configured value through `ConsensusFactory.normalizeConsensusProtocolClass` before using it. When the configuration uses the legacy `org.apache.iotdb.consensus.pipe.PipeConsensus` name or the implementation class name `org.apache.iotdb.consensus.pipe.IoTConsensusV2`, `ConfigNode` concluded that IoTConsensusV2 was not configured: - `createInitialConsensusPipes()` never created the `__consensus.*` pipes when a database was created; - `checkAndRepairConsensusPipes()` returned immediately, so `PipeMetaSyncer` could never repair the missing pipes; - `RouteBalancer` disabled the automatic data region leader balance (`IS_ENABLE_AUTO_LEADER_BALANCE_FOR_DATA_REGION` became `false`). Since the IoTConsensusV2 write path only writes the local state machine, the missing pipes silently degraded the data region replication factor to one: no error was reported, `syncLag` stayed at zero, and the region peers could all end up as followers. The value persisted by `SystemPropertiesUtils.storeSystemParameters()` is already normalized, so the degradation originated at the configuration boundary; on a restart, `ConfigNodeStartupCheck.checkSystemProperties()` overwrote `CONF` with the persisted canonical value and the cluster silently healed. ## Fix - Normalize once at the configuration boundary (`ConfigNodeConfig#setDataRegionConsensusProtocolClass`) so `CONF` never holds an alias regardless of the source (properties file, system properties, programmatic setup). - Normalize in `ConfigNodeDescriptor` when the value is read, and log a WARN when a legacy name is found, so the degradation is visible in the ConfigNode log. - Add `RegionMaintainHandler#isIoTConsensusV2Configured()` and use it at the four comparison sites (`createNewRegionPeer`, `createInitialConsensusPipes`, `checkAndRepairConsensusPipes`, `isIoTConsensusV2DataRegion`). - Normalize the cached value in `RouteBalancer`. - Normalize the value sent by a joining ConfigNode in `ConfigManager#checkConfigNodeGlobalConfig`, so a mixed-version cluster is not rejected during a rolling upgrade. ## Tests - `ConfigNodeConfigTest#testDataRegionConsensusProtocolClassNormalizesLegacyNames`: both aliases are stored in canonical form; canonical and Ratis values are preserved. - `RegionMaintainHandlerConsensusPipeTest#testCreatesMissingPipesWhenLegacyConsensusProtocolAliasConfigured`: the periodic self-healing path creates the pipes when the legacy alias is configured. - `RegionMaintainHandlerConsensusPipeTest#testCreatesInitialPipesWhenImplementationClassNameConfigured`: database creation creates the initial pipes when the implementation class name is configured. The three new tests fail on the unpatched code and pass with the fix. `RegionMaintainHandlerTest` (30 tests), `RemovePeerRestartConsensusTest` and `RestartDuringRemovePeerTest` (14 tests) and the `ConfigNodePropertiesTest` ArchUnit rule still pass. Both the `en` and the `zh` locale sources compile, and `mvn spotless:check -pl iotdb-core/confignode` passes. ## Note on existing clusters After upgrading, the pipes are recreated by `PipeMetaSyncer` on the ConfigNode leader, but data written while the pipes were missing only exists in the leader's state machine. Whether it is back-filled depends on the pipe/snapshot start semantics, so operators of an affected cluster should verify the replicas (for example with a backup or a replica consistency check) instead of assuming the history is repaired automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
