d-wang-commit opened a new pull request, #19003:
URL: https://github.com/apache/iotdb/pull/19003
## Description
### Restrict AUTO replacement checks to the requested region type
When minimum-count and slot-based growth do not apply, AUTO compares the
number of groups of the requested type with the number of disabled groups in
the database. The latter currently includes both SchemaRegion and DataRegion
groups.
With one running DataRegion group and one disabled SchemaRegion group, the
equal counts incorrectly trigger a new DataRegion group. When both groups are
disabled, the unequal counts prevent the required DataRegion replacement.
SchemaRegion allocation has the same problem.
Filter the existing disabled-group list by the requested consensus group
type before counting. This preserves the maximum limit and the existing
behavior for missing status-cache entries without adding a new API.
### Tests
- UT: added `PartitionManagerAutoExtensionTest` with six parameterized cases
covering spurious replacement, missed replacement, and the maximum limit for
both SchemaRegion and DataRegion. All six passed.
- Ran `mvn test -pl iotdb-core/confignode -am
-Dtest=PartitionManagerAutoExtensionTest,PartitionManagerProactiveExtensionTest
-Dsurefire.failIfNoSpecifiedTests=false`: 60 passed, 6 skipped, no failures or
errors. The skips are existing DataRegion-only cases under the SchemaRegion
parameter.
- Spotless passed for the changed files. The English reactor compilation
completed with the UT run; `mvn test-compile -pl iotdb-core/confignode -am -P
with-zh-locale -DskipTests` also passed.
- IT: none added or run; this change is confined to the ConfigNode
allocation condition.
### Side effects and risks
Only AUTO replacement decisions in mixed-type databases change. The existing
minimum, slot-based growth, maximum, and status-cache behavior are retained.
Filtering adds a linear pass over the database's already selected disabled
groups; no RPC, protocol, or persistence format changes are introduced.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design
(or naming) decision point and compare the alternatives with the designs
that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen
designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development
mailing list),
link to that discussion from this PR description and explain what have
changed in your final design
compared to your original proposal or the consensus version in the end of
the discussion.
If something hasn't changed since the original discussion, you can omit a
detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for
the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added unit tests covering the changed allocation condition and maximum
limit.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items
apply to every PR. Remove the items which are not done or not relevant to
the PR. None of the items
from the checklist above are strictly necessary, but it would be very
helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes)
in this PR
- PartitionManager: count only disabled RegionGroups of the requested type
in AUTO replacement decisions.
- PartitionManagerAutoExtensionTest: cover cross-type replacement and the
maximum limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]