Caideyipi commented on PR #18976: URL: https://github.com/apache/iotdb/pull/18976#issuecomment-6406932177
Self-review completed for commit `d267af3bfb9688ad713a964e1ed75766770edcd1`. I reviewed the `DeliveryLedger` extraction and the affected queue lifecycle paths, including ACK/NACK handling, requeue/recycle behavior, payload release, seek/close cleanup, WAL retention, and the reflection test update. I found no actionable correctness issues, so no code changes or push were needed. Validation: - `mvn -o test -pl iotdb-core/datanode -am -Dtest=ConsensusPrefetchingQueueDeliveryTest,ConsensusSubscriptionCommitStateTest -Dsurefire.failIfNoSpecifiedTests=false`: 33 tests passed. - `git diff --check`: passed. - A broader local `ConsensusPrefetchingQueue*Test` run reached DataNode test startup but the JVM exited because the review host could not allocate sufficient native memory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
