Caideyipi commented on PR #17865: URL: https://github.com/apache/iotdb/pull/17865#issuecomment-6407151081
Self-review passed for 8cf00e1c5ef4a9e1d5a56d800f102a254252492b. Reviewed the full PR diff and relevant context; all five actionable findings have been fixed and the review threads resolved. Fixes: - Derive the driver release version from Maven build metadata, consistently across Driver and both DatabaseMetaData implementations, while retaining JDBC API version 4.3. - Retain failed ResultSet/query cleanup and retry it before statement reuse; keep closed ResultSets unreadable and preserve cleanup errors. - Apply DataSource login timeout during connection/session establishment and restore the configured network read timeout afterward. - Include client key-store and SSL protocol properties in driver metadata, with password values redacted. - Localize the new JDBC errors and property descriptions in both locales and make affected test assertions locale-independent. Verification: - Passed Spotless with `mvn spotless:apply -P with-integration-tests -pl iotdb-client/jdbc,iotdb-client/service-rpc`. - Passed clean English unit tests: **110 Service-RPC + 237 JDBC**, zero failures/skips. - Passed clean `with-zh-locale` compilation of both affected modules and all **237 JDBC tests**, zero failures/skips. Surefire selected `org.apache.iotdb.jdbc.*Test` with `surefire.failIfNoSpecifiedTests=false` for the upstream module. - Passed focused clean packaging of both modules. Verified the build version, manifest and JDBC service registration in both the thin and bundled JDBC JARs. - Verified all 171 JDBC message keys and format placeholders match between English and Chinese; `git diff --check` passed. Clean test/package runs had task caching disabled. Verification limits: the complete Chinese Service-RPC test run still fails two unchanged assertions that expect English messages: `DeepCopyRpcTransportFactoryTest#testIndependentMaxFrameSizeConfigurations` and `TElasticFramedTransportTest#testSingularSize`. The fresh-repository full-reactor compile attempt was blocked before compilation by remote Maven Central DNS resolution while loading Develocity. Full-reactor compilation and integration tests remain unverified; no claim is made that all CI checks have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
