Caideyipi commented on PR #19011:
URL: https://github.com/apache/iotdb/pull/19011#issuecomment-6407369815

   Independent self-review passed at 
`824d51cb82ad83daf3014ce44c90f02d07f3c056`. No actionable issues were found, 
and no fixes were needed.
   
   Reviewed the complete 34-file diff against #18737 (`6862fc0`) and the 
`dev/1.3` base `63ae4d1`, including the removed implementation/tests and 
remaining callers. The target-specific removal of built-in OPC UA registrations 
is consistent with the source change. Retaining Bouncy Castle is necessary for 
`IoTDBOrderByIT`.
   
   The OPC DA tablet helper preserves the original event checks, 
conversion/transfer order, exception propagation and balanced reference release 
in `finally` for both event types. The holder name changes consistently to 
`OpcDaSink`; the TsFile default transfer/close path is preserved. The moved 
warning has matching English/Chinese keys, placeholders and the required hash. 
No production OPC UA/Milo references remain.
   
   Verification on JDK 17:
   
   - Fresh source compilation of the affected modules and downstream core 
modules completed for both `en` and `zh`, using separate initially empty Maven 
repositories and disabled build caching. The memory-constrained run used 
`-Xmx1536m`.
   - All 12 selected Maven test cases passed in each locale, with zero 
failures/errors/skips: `OpcDaSinkTest` (6), `PipeParametersTest` (2), and 
`PipeSinkSubtaskManagerTest` (4).
   - Helper equivalence, i18n key/placeholder parity and constant hash checks 
passed; `git diff --check` passed. The PR's four Linux/Windows JDK 17 unit-test 
checks are also green.
   
   Full reactor verification remains incomplete: the English `clean 
test-compile -DskipTests` and Chinese `clean test` attempts both exited 1 at 
`distribution`, which requires server/CLI/ConfigNode ZIP artifacts produced by 
the packaging phase. All preceding modules succeeded. Real OPC DA/COM server 
integration was not run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to