Caideyipi commented on PR #18055:
URL: https://github.com/apache/iotdb/pull/18055#issuecomment-6408568135

   Self-review passed after fixes in 9589f4289ef. All actionable findings from 
this review have been resolved.
   
   Fixed findings:
   - Concurrent polls could pass the in-flight limit check together and then 
exceed the limit. The limit check and event claim now share a dedicated lock in 
both pipe and consensus queues. Deterministic regression tests reproduce the 
race for pipe V1 and V2.
   - Consensus prefetch checked retained capacity at round entry, but inner 
pending/WAL, buffered-writer, and ordered-writer paths could still 
over-materialize or exceed the event cap. Those paths now account for in-flight 
events and reserve a slot for the lingering batch, while preserving the 
existing byte-based memory behavior.
   - Full queues scheduled recycling using the global interval instead of the 
topic override, including when topic recycling was disabled. Scheduling now 
honors the effective topic interval and becomes dormant for nonpositive 
intervals.
   - Event-capacity backpressure incorrectly disabled the separately bounded 
realtime admission queue, forcing unnecessary WAL fallback. Materialization now 
pauses without disabling that admission path.
   
   Also removed the two newly introduced untranslated debug message literals. 
Added regression coverage for pending/WAL/multi-writer delivery, ack/ackSilent 
recovery, retained capacity, and topic recycle overrides.
   
   Validation:
   - Reproduced 12 failures among 18 selected cases against the original PR 
head, 0733a179dfe.
   - After the fixes: 120 tests passed across all 10 
`SubscriptionPrefetchingQueue*Test` and `ConsensusPrefetchingQueue*Test` 
classes (0 failures, 0 ignored).
   - Compiled the affected production classes and the selected test classes 
with `javac --release 17`; also compiled the affected production classes with 
the Chinese message sources. Tests ran through JUnit 4 against the installed 
Maven dependency classpath, with the JVM opens required by the existing 
reflection-based test fixtures.
   - `mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode 
-Ddevelocity.off=true` and `git diff --check` passed.
   - Full Maven reactor and integration tests were not run. The remote Maven 
attempt could not resolve its build extension because Maven Central was 
unreachable and the internal mirror DNS lookup failed; verification used the 
focused local compilation/JUnit fallback described above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to