Caideyipi commented on code in PR #17872:
URL: https://github.com/apache/iotdb/pull/17872#discussion_r4374512862


##########
iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/schedule/queue/IndexedBlockingQueue.java:
##########
@@ -57,6 +59,7 @@ public abstract class IndexedBlockingQueue<E extends 
IDIndexedAccessible> {
    * @throws IllegalArgumentException if maxCapacity <= 0.
    */
   protected IndexedBlockingQueue(int maxCapacity, E queryHolder) {
+    Preconditions.checkArgument(maxCapacity > 0, "maxCapacity must be greater 
than 0.");

Review Comment:
   Please move this new exception text into CalcMessages constants in both en 
and zh. The repository AGENTS.md forbids inline user-facing English strings; 
the same new literal-message pattern also appears in 
IndexedBlockingReserveQueue, FixedPriorityBlockingQueue, FiniteSemaphore, and 
the Pipe class-loader warning. Please localize those additions together so the 
zh build receives translations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to