Caideyipi commented on PR #15807:
URL: https://github.com/apache/iotdb/pull/15807#issuecomment-6416100584

   Self-review passed after fixing two issues in 4601900bfab.
   
   - Capture the readable request body size before dispatch in both receivers, 
so buffer prefixes are excluded and parsing cannot change the byte count.
   - Use the registered DataNode handshake labels when removing request-size 
rates, so unbinding removes the metrics and rebinding starts with fresh counts.
   
   Added regression coverage for prefixed read-only buffers, GZIP request 
accounting, and metric unbinding/rebinding.
   
   Validation:
   - Spotless apply with `with-integration-tests`: passed.
   - Clean-source build of the matching TsFile dependencies and the affected 
29-module IoTDB reactor on JDK 17: passed.
   - Focused unit tests (`PipeDataNodeReceiverMetricsTest` and 
`IoTDBDataNodeReceiverMetricsTest`): **3 passed, 0 failures, 0 errors, 0 
skipped**.
   - GitHub CI is still running.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to