Caideyipi commented on PR #19026: URL: https://github.com/apache/iotdb/pull/19026#issuecomment-6433733229
Self-review completed after inspecting the full PR diff and the related client, planner, consensus, and schema execution paths. I found and fixed three actionable issues: - `InternalCreateMultiTimeSeriesNode.splitByPartition` did not enforce `maxMeasurementNumOfInternalRequest`, so a mixed-alignment request could produce an oversized per-region consensus request. Added per-region splitting and regrouping consistent with `CreateMultiTimeSeriesNode` (`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metadata/write/InternalCreateMultiTimeSeriesNode.java:151-216`). - `MeasurementGroup.serialize` omitted `propsList`, so non-aligned properties such as `max_point_number` were lost when the plan crossed consensus serialization. Added a marked, backward-compatible props section and covered the round trip in `iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/planner/node/metadata/write/MetadataWriteNodeSerDeTest.java:236-249` (`MeasurementGroup.java:282-449`). - `MeasurementGroup.split()` returned `subList` views. Execution removes existing measurements from a split, which could mutate sibling split requests. Split fields now use independent list copies (`MeasurementGroup.java:204-225`). Validation: - `mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode` passed. - `git diff --check` passed. - Local datanode test compilation did not reach the tests because the checkout has pre-existing cross-module/stale-dependency compilation errors (including missing `InternalDatabaseUtils`, missing `SessionInfo.isInternal/setInternal`, pipe constructor mismatches, and existing RPC interface mismatches). A full-reactor `test-compile` attempt also stopped after JVM native memory/page-file exhaustion in `node-commons`. - The newly added remote tests were reported as passing, but were not run locally: `SessionTest#testCreateMultiTimeseriesWithAlignment`, `SessionConnectionTest#testCreateMultiTimeseriesWithAlignment*`, `SessionPoolTest#testCreateMultiTimeseriesWithAlignment`, `StatementGeneratorTest#testCreateMultiTimeSeriesWithAlignment*`, and `IoTDBSessionSimpleIT#createMultiTimeseriesWithAlignment*`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
