Caideyipi commented on PR #19034: URL: https://github.com/apache/iotdb/pull/19034#issuecomment-6459493786
Independent re-review completed for the full current PR diff and relevant context. No source-behavior or test-logic issues were found. One comment-only finding was fixed in e40e0f003d831b506d25d19621eaf03541d392f7: [ConsensusPrefetchingQueue.java:315](https://github.com/Caideyipi/iotdb/blob/e40e0f003d831b506d25d19621eaf03541d392f7/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java#L315) still described initialization using a poll progress hint. The comment now describes successful initialization from committed progress (or its fallback), matching the implementation. Validation: `mvn spotless:apply -P with-integration-tests` completed successfully, and `git diff --check` passed. The author-provided remote clean-reactor result is 67 tests passed, 0 failures and 0 errors. The new `ConsensusPrefetchingQueueDeliveryTest#testDeactivationReplaysUncommittedEventInsteadOfUsingPollProgress` has not been run locally; tests were not rerun for this comment-only fix. The remote head was verified as e40e0f003d831b506d25d19621eaf03541d392f7. This PR remains open and non-draft under the author's explicit comment-only exception. This session performed one review round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
