siddiqueirshad opened a new pull request, #19044:
URL: https://github.com/apache/iotdb/pull/19044

   <!--
   Thank you for contributing to Apache IoTDB!
   Please read the contribution guidelines: 
https://iotdb.apache.org/Community/Community-Project-Committers.html
   -->
   
   ### Description
   In `scripts/sbin/windows/start-edge.bat`, `stop-datanode.bat`, and 
`stop-standalone.bat`, any existing `IOTDB_HOME` environment variable is 
honored using `if NOT DEFINED IOTDB_HOME set "IOTDB_HOME=%cd%"`.
   However, `stop-edge.bat` unconditionally executed `set "IOTDB_HOME=%cd%"`. 
If an IoTDB Edge node was started with `IOTDB_HOME` set to an explicit path 
(e.g., via a symbolic link, junction, or custom configuration path), 
`start-edge.bat` launched the JVM process with `-DIOTDB_HOME="..."` using that 
environment variable, but `stop-edge.bat` overwrote `IOTDB_HOME` with the 
physical resolved path. This prevented `stop-edge.bat` from matching and 
stopping the running `java.exe` process.
   
   Fixes #19005.
   
   ### Changes
   - Updated `scripts/sbin/windows/stop-edge.bat` to check `if NOT DEFINED 
IOTDB_HOME set "IOTDB_HOME=%cd%"`, consistent with `start-edge.bat` and the 
other Windows stop scripts.
   
   ### Checklist
   - [x] All commits signed off (`git commit -s`)
   - [x] Verified behavior on Windows scripts
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to