Caideyipi commented on PR #19040:
URL: https://github.com/apache/iotdb/pull/19040#issuecomment-6485608330

   Re-review completed for `7801f53cd621788b4714b74836b87a9052c1ba13` against 
`8cdc9681d0141fa51cfd0dc120b67a7383270865`. No actionable findings; no fixes 
were needed.
   
   Reviewed the complete three-file diff and the surrounding V1/V2 poll, 
in-flight requeue, response reset, acknowledgement, and snapshot termination 
paths. The disconnect reset preserves the nack count, response-size requeue 
preserves the current response, and the queue monitor plus in-flight-first 
completion check covers both event-transfer directions.
   
   Validation:
   
   - Rebuilt the required 28-module source closure locally on Windows with 
`clean test`, `-pl iotdb-core/datanode -am`, and the Develocity build cache 
disabled. Maven exited with code 0; all 482 goals executed.
   - Ran `SubscriptionPrefetchingQueueRecoveryTest` and 
`SubscriptionPrefetchingQueueRecycleIntervalTest`: **4 tests, 0 failures, 0 
errors, 0 skipped**. All tests newly added by this PR ran locally.
   - `git diff --check` passed and the review worktree remained unchanged.
   - Remote validation attempts were blocked before compilation by Develocity 
extension dependency resolution; the successful result above is from the local 
fallback.
   
   Existing CI failures remain outside this diff and were left unchanged:
   
   - 
[ZH-Locale-Compile](https://github.com/apache/iotdb/actions/runs/40675095965/job/122771357852)
 successfully compiled DataNode with the Chinese locale, then failed in 
distribution dependency resolution because the server, CLI, and ConfigNode ZIP 
artifacts were unavailable. The workflow should prepare those artifacts before 
resolving the distribution module.
   - The [Sonar quality 
gate](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=19040) 
reports issues in unchanged files. Its issue API returned no findings for 
either changed production file; those existing alerts need separate triage.
   
   No full distribution build or additional cluster integration-test run was 
performed in this review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to