Caideyipi commented on PR #19042: URL: https://github.com/apache/iotdb/pull/19042#issuecomment-6487784868
Initial independent self-review completed for `efc531082ef8bd2398cb6f4738816542afe670d7`, against base `8cdc9681d0141fa51cfd0dc120b67a7383270865`. I inspected the complete diff, all four affected files, and the relevant WAL roll, retention, commit, replay, and seek call paths. No actionable source-behavior or test-logic issues were found; no fixes were needed. - Retention now rechecks a formerly live WAL after a roll even when ACK progress is unchanged. The old writer is sealed before the new version is published; uncovered requirements, progress rollback, and metadata-read failures remain conservative. - Fast-forward distinguishes an already-passed predecessor from a current or deferred reader. Buffered requests and the newly skipped prefix still require writer-progress coverage, including followers without local search indexes. Tail-plus-one positioning preserves those checks. I found no new exception, lock-order, or resource-lifecycle issue in the affected paths. - The regression assertions exercise the unchanged-ACK roll, repeated advances after reclaiming the prefix and intermediate file, and tail-plus-one probes after reclaiming covered history. They also retain the uncovered-follower assertion. Static tracing shows where the original logic would fail these assertions; counter-runs against the original implementation were not executed. Validation: - `git diff --check` passed. - The supplied clean-reactor log from a separate source tree reports 86 tests: 85 passed, zero failures/errors, and one existing opt-in performance test skipped. This does not establish an independent clean build of this exact upstream revision. - This round's independent clean-reactor attempt timed out fetching the exact source revision before Maven started. The build, focused tests, and original-implementation counter-runs therefore remain unrun. Local fallback lacked sufficient available virtual memory. - Upstream CI reports passing JDK 17 unit-test jobs on Linux and Windows. [ZH compilation](https://github.com/apache/iotdb/actions/runs/40676604798/job/122776507674) failed at distribution dependency resolution for missing server/CLI/ConfigNode ZIP artifacts. The [SonarCloud quality gate](https://github.com/apache/iotdb/runs/122782139941) remains failed; the retrieved annotations in the affected production files are outside the changed hunks. These statuses are not reported as passing. The independent review gate passed. I rechecked that the remote head still matched the reviewed revision, marked the PR ready for review, and verified its non-draft state. <!-- pr19042-initial-self-review-efc5310 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
