Caideyipi commented on PR #19055: URL: https://github.com/apache/iotdb/pull/19055#issuecomment-6499558337
Independent review of head `24d03808a584995ef366020e0bba5c6287d9b5b0` against the current `master` base `28c5028bb462403315e46319b57e9beb96ffaa69` found no actionable source-behavior or test-logic issues. Empty DropPipe lists now skip both DataNode Pipe metadata RPC paths while consumer-group metadata synchronization still runs. The non-empty Pipe path and its failure handling are unchanged. The regression test would fail against the original empty-list broadcast, verifies both RPC methods are not called, and confirms consumer-group synchronization. The local Surefire report records 5 tests passed with no failures, errors, or skips. The workflow record reports Spotless and a full clean reactor compilation passed before publication; I did not rerun those build steps during this read-only review. The Apache-baseline Failsafe IT could not execute because Subscription is disabled in that environment; the recorded Subscription-enabled run passed. GitHub checks were still in progress when checked. The PR remains Draft as requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
