Caideyipi commented on PR #19076: URL: https://github.com/apache/iotdb/pull/19076#issuecomment-6571665259
Initial independent review completed with no actionable findings in the full three-file diff or relevant context. - Reviewed local revision and confirmed remote source-branch/PR head: `2f8a392f7a1f68f48f5e90914a5095f8dd44c807` (base: `999721fcafd5e95ff5f3de931ad34175ea315946`). No fixes or new commits were needed; no push was required. - Checked task reservations for concurrent submissions, the last-empty-poll handoff, stopped-executor completion, queue cleanup, and the scanner integration-test setup and assertions. - `git diff --check` passed. Existing CI reports Linux and Windows DataNode unit-test success and successful Chinese-locale compilation. The completed Linux DataNode job reports 5,662 unit tests, zero failures/errors and 48 skips, followed by `BUILD SUCCESS`. Builds and executable tests were not repeated in this review. - Some CI jobs are still running, and AINode is cancelled. The SonarCloud reliability failure points to unchanged `PipeTaskInfo.java:1165`, outside this PR's diff; it was not modified or independently confirmed as a defect here. The loader warnings concern the shared monitor protecting executor/task-count transitions and the rollback/rethrow when task submission fails; both have a correctness purpose. The independent-review gate passes for the reviewed revision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
